[Issue 11581][broker] feat:pass the executor to RateLimiter in ResourceGroupPublishLimiter

[leizhiyuan]

background

Fixes #11581

Motivation

we need to pass the executor to RateLimiter in ResourceGroupPublishLimiter

Modifications

pass the executor to RateLimiter in ResourceGroupPublishLimiter

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

• Dependencies (does it add or upgrade a dependency): (no)
• The public API: (no)
• The schema:(no)
• The default values of configurations: (no)
• The wire protocol: (no)
• The rest endpoints: (no)
• The admin cli options:(no)
• Anything that affects deployment: (no)

Documentation

For contributor

For this PR, do we need to update docs?

no, there is no change for users.

[Anonymitaet]

Thanks for providing doc-related info!

[lhotari]

the default value is false, so there's no need to set isDispatchOrPrecisePublishRateLimiter

[leizhiyuan]

done

[leizhiyuan]

the failed tase case runs ok in local machine

[lhotari]

the failed tase case runs ok in local machine

@leizhiyuan There are quite a few flaky tests. I assume you faced #11096 .

When you suspect a flaky test, please search in the GitHub issue with the short name of the test class for possible reported flaky tests.

It is possible to retry a failed CI build by adding a comment "/pulsarbot rerun-failure-checks" to the PR.

• Before retrying a failed build, please check the failure in the logs. Check the issue tracker whether the test failure has been reported as a flaky test. If not, please report it.
• If it has been reported, please add a comment about facing a flaky issue in a specific build (provide link to log line in GitHub Actions log).

Reporting a new Flaky issue can be done by choosing "Flaky test" on the new
issue page https://github.com/apache/pulsar/issues/new/choose .
Searching flaky issues:
https://github.com/apache/pulsar/issues?q=is%3Aissue+is%3Aopen+flaky+sort%3Aupdated-desc
(enter "flaky" or the test method name as the search query)

[bharanic-dev]

@leizhiyuan Thank you for taking care of this. Passing the Executor was one of the tasks in my TODO list (which I why I left the comment in the code). Glad you were able to get to it before I could.

Just to clarify though, I don't think this addresses any flaky tests. The flaky tests reported in:
#11096
#11601

are because of a code issue, where the zookeeper watch events were getting fixed. The race condition was reported in #11157 and fixed in #11198

[bharanic-dev]

LGTM