[stats] Do not expose meaningless stats for publisher #11454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jul 26, 2021
codelipenghui
added
release/2.8.1
type/enhancement
|
@massakam Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
|
@Anonymitaet Removed these fields from the json example in the documentation: 637b7aa |
massakam
added
the
doc
sijie
approved these changes
Jul 28, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
Currently, publisher stats includes some fields that are meaningless for users. ``` count producerNameOffset producerNameLength addressOffset addressLength connectedSinceOffset connectedSinceLength clientVersionOffset clientVersionLength stringBuffer ``` These cause the size of the json data to grow and should not be exposed. Add the `@JsonIgnore` annotation to the above fields. This is a modification similar to #11005. (cherry picked from commit d3c44ba)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Currently, publisher stats includes some fields that are meaningless for users. ``` count producerNameOffset producerNameLength addressOffset addressLength connectedSinceOffset connectedSinceLength clientVersionOffset clientVersionLength stringBuffer ``` These cause the size of the json data to grow and should not be exposed. ### Modifications Add the `@JsonIgnore` annotation to the above fields. This is a modification similar to apache#11005.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, publisher stats includes some fields that are meaningless for users.
These cause the size of the json data to grow and should not be exposed.
Modifications
Add the
@JsonIgnoreannotation to the above fields. This is a modification similar to #11005.