Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Fix producing messages when preciseTopicPublishRateLimiterEnable=true #11442

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jul 23, 2021

Fixes #10603

Motivation

See #10603

Modifications

  • modify PublishRateLimiterDisable to always return true from tryAcquire method

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch

nice to see a new test to cover this

@rdhabalia
Copy link
Contributor

what's the code change in this PR? I don't see any changes here except adding test?

@lhotari
Copy link
Member Author

lhotari commented Jul 28, 2021

what's the code change in this PR? I don't see any changes here except adding test?

@rdhabalia #11446 was merged before this PR and included the change. That's the reason why the change doesn't show up.

@lhotari lhotari merged commit b166701 into apache:master Aug 2, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants