[fix master build] use entryTimestamp for expiry checking in internalGetMessageIdByTimestamp
#11220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
changed the title
entryTimestamp for expiry checking in internalGetMessageIdByTimestampentryTimestamp for expiry checking in internalGetMessageIdByTimestamp
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@freeznet thanks for your contribution. For this PR, do we need to update docs? |
@Anonymitaet thanks for asking, this is just a hotfix to the master branch, so no doc required. |
tuteng
approved these changes
Jul 6, 2021
tuteng
added
area/build
type/bug
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation apache#11014 introduced `getEntryTimestamp` and removed `deserializeBrokerEntryMetaDataFirst`, but apache#11139 is still using `deserializeBrokerEntryMetaDataFirst`, and it breaks master branch. ### Modifications use `entryTimestamp` for expiry checking in `internalGetMessageIdByTimestamp` ### Verifying this change - [x] Make sure that the change passes the CI checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#11014 introduced
getEntryTimestampand removeddeserializeBrokerEntryMetaDataFirst, but #11139 is still usingdeserializeBrokerEntryMetaDataFirst, and it breaks master branch.Modifications
use
entryTimestampfor expiry checking ininternalGetMessageIdByTimestampVerifying this change