Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky test testUpdateDynamicLocalConfiguration #11115

Merged
merged 1 commit into from Jul 22, 2021
Merged

fix flaky test testUpdateDynamicLocalConfiguration #11115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
View file
Open in desktop
Expand Up @@ -615,18 +615,18 @@ public void testInvalidDynamicConfigContentInZK() throws Exception {
*
* @throws Exception
*/
@Test
@Test(timeOut = 30000)
public void testUpdateDynamicLocalConfiguration() throws Exception {
// (1) try to update dynamic field
final long initValue = 30000;
final long shutdownTime = 10;
pulsar.getConfiguration().setBrokerShutdownTimeoutMs(initValue);
// update configuration
admin.brokers().updateDynamicConfiguration("brokerShutdownTimeoutMs", Long.toString(shutdownTime));
Awaitility.await().until(()
-> pulsar.getConfiguration().getBrokerShutdownTimeoutMs() != initValue);
// verify value is updated
assertEquals(pulsar.getConfiguration().getBrokerShutdownTimeoutMs(), shutdownTime);
Awaitility.waitAtMost(30, TimeUnit.SECONDS).untilAsserted(() -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the delay of zk watch exceed 10 seconds?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have logs?

30 seconds is very much.

And also we are using some MockZookeeper here probably

assertEquals(pulsar.getConfiguration().getBrokerShutdownTimeoutMs(), shutdownTime);
});
}

@Test
Expand Down