Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] Remove redundant method for CompletableFuture timeout handling #10970

Merged
merged 1 commit into from Jun 20, 2021
Merged

[Broker] Remove redundant method for CompletableFuture timeout handling #10970

merged 1 commit into from Jun 20, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 18, 2021

Motivation

Modifications

  • Remove redundant methods added to FutureUtil & refactor code in BrokerService to use the existing solution for timeout handling.

@lhotari
Copy link
Member Author

lhotari commented Jun 18, 2021

@rdhabalia @merlimat Please review

@lhotari lhotari requested a review from aahmed-se June 19, 2021 18:15
@merlimat merlimat added this to the 2.9.0 milestone Jun 20, 2021
@merlimat merlimat added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Jun 20, 2021
@merlimat merlimat merged commit ae16ec4 into apache:master Jun 20, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
@lhotari @yangl
[Broker] Remove redundant method for CompletableFuture timeout handli…
eb830f4 
…ng (apache#10970)
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@lhotari @ciaocloud
[Broker] Remove redundant method for CompletableFuture timeout handli…
b687fc3 
…ng (apache#10970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@eolivelli eolivelli Awaiting requested review from eolivelli

@sijie sijie Awaiting requested review from sijie

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@aahmed-se aahmed-se Awaiting requested review from aahmed-se

Assignees

@lhotari lhotari

Labels
type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lhotari @merlimat