fix Consumer#getLastMessageId after setting brokerEntryMetadataInterceptors #10952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a unit test? |
hangc0276
requested review from
cckellogg,
sijie,
hangc0276,
BewareMyPower and
codelipenghui
hangc0276
requested changes
Jun 17, 2021
There was a problem hiding this comment.
- There are many places just parse entry data without skip possiable broker metadata, and they may throw exceptions when configured broker metadata interceptor in broker.conf. Woud you please check all the code block and fix them?
- Would you please add the tests to cover this case and protect your code？
hangc0276
added
area/broker
release/2.8.1
type/bug
|
Close this PR by #10968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #10950