New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Exclude producers for geo-replication from publishers field of topic stats #22556
Conversation
...-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22556 +/- ##
============================================
+ Coverage 73.57% 73.87% +0.29%
+ Complexity 32624 2744 -29880
============================================
Files 1877 1885 +8
Lines 139502 140516 +1014
Branches 15299 15450 +151
============================================
+ Hits 102638 103804 +1166
+ Misses 28908 28656 -252
- Partials 7956 8056 +100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@lhotari PTAL |
442bb30
to
6119eac
Compare
Resolved conflicts. |
96aa9f6
to
342d63e
Compare
342d63e
to
14a4e8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #22442
Motivation
Please refer to #22442.
Modifications
Exclude producers for geo-replication from the
publishers
field in topic-stats and broker-stats.Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete