Skip to content

Commit

Permalink
Fix flaky test testOffloadV2 (#10350)
Browse files Browse the repository at this point in the history
### Motivation 
triggerOffload takes some time

```
Error:  testOffloadV2(org.apache.pulsar.broker.admin.AdminApiOffloadTest)  Time elapsed: 0.127 s  <<< FAILURE!
java.lang.AssertionError: expected [SUCCESS] but found [RUNNING]
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
	at org.testng.Assert.assertEquals(Assert.java:122)
	at org.testng.Assert.assertEquals(Assert.java:617)
	at org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffload(AdminApiOffloadTest.java:135)
	at org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffloadV2(AdminApiOffloadTest.java:150)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
```
  • Loading branch information
315157973 committed Apr 26, 2021
1 parent 2ede152 commit 69a173a
Showing 1 changed file with 3 additions and 2 deletions.
Expand Up @@ -132,8 +132,9 @@ private void testOffload(String topicName, String mlName) throws Exception {

admin.topics().triggerOffload(topicName, currentId);

assertEquals(admin.topics().offloadStatus(topicName).status,
LongRunningProcessStatus.Status.SUCCESS);
Awaitility.await().untilAsserted(() ->
assertEquals(admin.topics().offloadStatus(topicName).status,
LongRunningProcessStatus.Status.SUCCESS));
MessageIdImpl firstUnoffloaded = admin.topics().offloadStatus(topicName).firstUnoffloadedMessage;
// First unoffloaded is the first entry of current ledger
assertEquals(firstUnoffloaded.getLedgerId(), info.ledgers.get(1).ledgerId);
Expand Down

0 comments on commit 69a173a

Please sign in to comment.