-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Broker] Fix async response filter (#11052)
### Motivation Currently, the response filter couldn't process async responses correctlly, the response interceptor may be called before the async response returning. ### Modifications Add listener when using async request. ### Verifying this change Add a new test to verify the response interceptor is called after async response returning. (cherry picked from commit 3c8d210)
- Loading branch information
1 parent
ab00b99
commit 5fa23c7
Showing
5 changed files
with
180 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AsyncResponseTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
package org.apache.pulsar.broker.admin.v3; | ||
|
||
|
||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import javax.ws.rs.GET; | ||
import javax.ws.rs.Path; | ||
import javax.ws.rs.PathParam; | ||
import javax.ws.rs.container.AsyncResponse; | ||
import javax.ws.rs.container.Suspended; | ||
import javax.ws.rs.core.Response; | ||
import lombok.extern.slf4j.Slf4j; | ||
import org.apache.pulsar.broker.web.RestException; | ||
|
||
/** | ||
* Async response test. | ||
*/ | ||
@Slf4j | ||
@Path("/test") | ||
public class AsyncResponseTest { | ||
|
||
@GET | ||
@Path("/asyncGet/{topicName}/{delayMilliseconds}") | ||
public void asyncGet(@Suspended AsyncResponse response, | ||
@PathParam("topicName") String topicName, | ||
@PathParam("delayMilliseconds") long delayMilliseconds) { | ||
new Thread(() -> { | ||
if (delayMilliseconds > 0) { | ||
try { | ||
Thread.sleep(delayMilliseconds); | ||
} catch (InterruptedException e) { | ||
log.error("Failed to handle test method asyncGet.", e); | ||
response.resume(new RestException(e)); | ||
} | ||
} | ||
response.resume(Response.noContent().build()); | ||
}).start(); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters