Skip to content

Commit

Permalink
[Branch-2.8]fix testSetReplicatedSubscriptionStatus run failed (#11661)
Browse files Browse the repository at this point in the history
### Motivation
The test `testSetReplicatedSubscriptionStatus ` add by #10790, and the code `persistentTopics.createPartitionedTopic(response, testTenant, testNamespace, topicName, 2, true);` `createLocalTopicOnly` set `true`. However, when the PR cherry-pick to branch-2.8, this commit `https://github.com/apache/pulsar/commit/0706bc01a428a9405c671a0f80fb54faccdd26e6`, which lead the test run failed.
  • Loading branch information
hangc0276 committed Aug 13, 2021
1 parent dd796d8 commit 468eedc
Show file tree
Hide file tree
Showing 29 changed files with 29 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci-build-macos.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-cpp-build-centos7.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
paths:
- '.github/workflows/**'
- 'pulsar-client-cpp/**'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-cpp-build-windows.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
paths:
- '.github/workflows/**'
- 'pulsar-client-cpp/**'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-cpp.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-go-functions-style.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
paths:
- '.github/workflows/**'
- 'pulsar-function-go/**'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-go-functions-test.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
paths:
- '.github/workflows/**'
- 'pulsar-function-go/**'
Expand Down
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-cli.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-function.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-messaging.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-process.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-schema.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-sql.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-standalone.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-thread.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-tiered-filesystem.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-tiered-jcloud.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-integration-transaction.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-license.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-shade-test.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-broker-broker-gp1.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-broker-broker-gp2.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-broker-client-api.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-broker-client-impl.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-broker-jdk8.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-broker-other.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-proxy.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit.yaml
Expand Up @@ -22,6 +22,7 @@ on:
pull_request:
branches:
- master
- branch-*
push:
branches:
- branch-*
Expand Down
Expand Up @@ -803,7 +803,7 @@ public void testSetReplicatedSubscriptionStatus() {
// 3) Create the partitioned topic
response = mock(AsyncResponse.class);
ArgumentCaptor<Response> responseCaptor = ArgumentCaptor.forClass(Response.class);
persistentTopics.createPartitionedTopic(response, testTenant, testNamespace, topicName, 2, false);
persistentTopics.createPartitionedTopic(response, testTenant, testNamespace, topicName, 2, true);
verify(response, timeout(10000).times(1)).resume(responseCaptor.capture());
Assert.assertEquals(responseCaptor.getValue().getStatus(), Response.Status.NO_CONTENT.getStatusCode());

Expand Down Expand Up @@ -857,5 +857,4 @@ public void testSetReplicatedSubscriptionStatus() {
verify(response, timeout(10000).times(1)).resume(responseCaptor.capture());
Assert.assertEquals(responseCaptor.getValue().getStatus(), Response.Status.NO_CONTENT.getStatusCode());
}

}

0 comments on commit 468eedc

Please sign in to comment.