Improve error logs in BacklogQuotaManager

apache · Aug 2, 2021 · 425bfe9 · 425bfe9
1 parent 1fc7e3b
commit 425bfe9
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java
@@ -191,13 +191,13 @@ private void dropBacklogForSizeLimit(PersistentTopic persistentTopic, BacklogQuo
                 }
                 // Skip messages on the slowest consumer
                 if (log.isDebugEnabled()) {
-                    log.debug("Skipping [{}] messages on slowest consumer [{}] having backlog entries : [{}]",
-                            messagesToSkip, slowestConsumer.getName(), entriesInBacklog);
+                    log.debug("[{}] Skipping [{}] messages on slowest consumer [{}] having backlog entries : [{}]",
+                            persistentTopic.getName(), messagesToSkip, slowestConsumer.getName(), entriesInBacklog);
                 }
                 slowestConsumer.skipEntries(messagesToSkip, IndividualDeletedEntries.Include);
             } catch (Exception e) {
-                log.error("Error skipping [{}] messages from slowest consumer : [{}]", messagesToSkip,
-                        slowestConsumer.getName());
+                log.error("[{}] Error skipping [{}] messages from slowest consumer [{}]", persistentTopic.getName(),
+                        messagesToSkip, slowestConsumer.getName(), e);
             }
 
             // Make sure that unconsumed size is updated every time when we skip the messages.
@@ -250,7 +250,7 @@ private void dropBacklogForTimeLimit(PersistentTopic persistentTopic, BacklogQuo
                     ledgerInfo = mLedger.getLedgerInfo(ledgerId).get();
                 }
             } catch (Exception e) {
-                log.error("Error resetting cursor for slowest consumer [{}]: {}",
+                log.error("[{}] Error resetting cursor for slowest consumer [{}]", persistentTopic.getName(),
                         mLedger.getSlowestConsumer().getName(), e);
             }
         }