New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the old connection to make sure the broker drops the producer on its side #677
base: master
Are you sure you want to change the base?
Conversation
ff7b771
to
bda4d40
Compare
83d3c3c
to
e624f23
Compare
@cckellogg PTAL, thanks |
@@ -858,13 +858,14 @@ func (c *connection) Close() { | |||
c.Lock() | |||
cnx := c.cnx | |||
c.Unlock() | |||
c.changeState(connectionClosed) | |||
c.changeState(connectionClosing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does changing the state here to connectionClosing
and then changing it to connectionClosed
later fix the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not to say that the problem is solved, but first change the state to connectionClosing
, the logic is more rigorous, I modified the description of the PR, it does not mean that the issue is fixed, but it is related to investigating this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no intermediate connectionClosing
state, other threads may start to create new connections in GetConnection
before the current cnx
is really closed. This is a mistake in itself. State transitions should be stricter. You can see that the network connection state transition of the java client is very rigorous.
If we can ensure that the state transition is more rigorous, set the state to connectionClosing
before cnx
closed, which can prevent other threads to create a new connection. This may be able to solve the issue #676 that the old connection was not closed, and the new connection has initiated a request, even if this is not the root cause of the problem.
Master Issue: #676
Motivation
When reconnecting to the server, the old connection should be closed.
Modifications
Close the old connection to make sure the broker drops the producer on its side
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation