Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect acknowledgment behavior in the listener of the multi-t… #423

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Apr 3, 2024

Motivation

apache/pulsar-client-node#371

Modifications

  • Add the message to the unacknowledged tracker before call the listener.

Verifying this change

  • Add testMultiConsumerListenerAndAck to cover it.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@BewareMyPower BewareMyPower merged commit 3f0b33b into apache:main Apr 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants