Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin versions-maven-plugin to 2.13.0 #9993

Conversation

jadami10
Copy link
Contributor

bugfix

I'm not sure how often this repo is hitting this yet, but our fork got bit by builds randomly failing yesterday. https://github.com/apache/pinot/actions/runs/3702140693/jobs/6272088585 is an example of this failure.

See mojohaus/versions#848 and aws/aws-sdk-java-v2#3623 for more context, but TLDR, latest version of versions-maven-plugin is broken.

@codecov-commenter
Copy link

Codecov Report

Merging #9993 (8a609b1) into master (8bb551e) will decrease coverage by 2.53%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9993      +/-   ##
============================================
- Coverage     70.39%   67.85%   -2.54%     
+ Complexity     5662     5460     -202     
============================================
  Files          1991     1484     -507     
  Lines        107229    78162   -29067     
  Branches      16295    12487    -3808     
============================================
- Hits          75481    53040   -22441     
+ Misses        26476    21369    -5107     
+ Partials       5272     3753    -1519     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 67.85% <ø> (+<0.01%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/pinot/server/access/AccessControlFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/TableDeletionMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...not/common/exception/HttpErrorStatusException.java 0.00% <0.00%> (-100.00%) ⬇️
... and 747 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jadami10
Copy link
Contributor Author

jadami10 commented Dec 15, 2022

looks like 2.14.1 release with a fix. I can pin up to that or stay pinned to 2.13.0 if we don't want to take an upgrade in the same PR. But we should definitely pin this. let me know

@siddharthteotia siddharthteotia merged commit 7eba70c into apache:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants