open javac modules for google-java-format #8531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
jdk17-codeformat
branch
2 times, most recently
from
53fe64d
to
78f57de
Compare
xiangfu0
reviewed
Apr 13, 2022
| @@ -48,7 +48,14 @@ jobs: | |||
| NEW_COMMIT: ${{ github.event.inputs.newCommit }} | |||
| WORKING_DIR: /tmp/compatibility-verifier | |||
| TEST_SUITE: ${{ matrix.test_suite }} | |||
| MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false | |||
| MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \ | |||
There was a problem hiding this comment.
is this multi-line with backslash the correct format?
or you can try this one:
MAVEN_OPTS: >
-Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25
-Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
...
There was a problem hiding this comment.
You may also need to modify the script a bit to let it trigger the job once to kick off the action tasks
There was a problem hiding this comment.
good catch. how do I force it to run?
There was a problem hiding this comment.
Just add a newline in pom.xml should trigger it. You can revert it back once the test is done
richardstartin
force-pushed
the
jdk17-codeformat
branch
from
78f57de
to
1facf14
Compare
xiangfu0
reviewed
Apr 13, 2022
richardstartin
force-pushed
the
jdk17-codeformat
branch
from
1facf14
to
1d41049
Compare
|
@xiangfu0 it builds. I will revert the dummy commit. |
👍 |
richardstartin
force-pushed
the
jdk17-codeformat
branch
from
1d41049
to
c24c741
Compare
xiangfu0
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google-java-format is JK17 incompatible, having dependencies on Javac internals, so needs some modules exported to run on JDK17. See more here: google/google-java-format#612