HDDS-10820. Freon tool DN-Echo to support GRPC and Ratis read/write mode #6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
reviewed
May 6, 2024
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/DNRPCLoadGenerator.java
Show resolved
Hide resolved
|
LGTM to me, just one nit. |
Change-Id: Ie0dd51b7565d0bdd4d3c5e2028df3d6239261aba
|
The review comment was addressed. Merging the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-10820. Freon tool DN-Echo to support GRPC and Ratis read/write mode
Please describe your PR in detail:
HDDS-10442 added a freon tool dn-echo to microbenchmark the performance of client to DN communication.
This PR aims to enhance the tool by testing client/DataNode in different transport/modes:
(1) Ratis write mode (CLI parameters: --ratis)
(2) Ratis read mode (CLI parameters: --ratis --read-only)
(3) Grpc mode (default)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10820
How was this patch tested?
Freon mini cluster test, also manually tested on a real cluster.