HDDS-10772. [Ozone-Streaming] Stream write metric is wrong #6610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Apr 30, 2024
| @@ -212,7 +219,9 @@ void assertOpen() throws IOException { | |||
| public void close() throws IOException { | |||
| if (closed.compareAndSet(false, true)) { | |||
| try { | |||
| putBlockRequest.set(closeBuffers(buffers, super::writeFileChannel)); | |||
| final long l = Time.monotonicNow(); | |||
There was a problem hiding this comment.
We should use more meaningful variable names, like start.
Suggested change
| final long l = Time.monotonicNow(); | |
| final long start = Time.monotonicNow(); |
There was a problem hiding this comment.
Sure. Thanks @jojochuang .
| writeFileChannelWithMetrics(l)); | ||
| } | ||
|
|
||
| private WriteMethod writeFileChannelWithMetrics(long l) { |
There was a problem hiding this comment.
Suggested change
| private WriteMethod writeFileChannelWithMetrics(long l) { | |
| private WriteMethod writeFileChannelWithMetrics(long start) { |
ivandika3
changed the title
guohao-rosicky
force-pushed
the
guohao-HDDS-10772-dev
branch
from
7d860a3
to
3eb3f89
Compare
szetszwo
reviewed
May 8, 2024
There was a problem hiding this comment.
@guohao-rosicky , thanks for working on this! How about we simply measure the time in writeFileChannel as below?
diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/KeyValueStreamDataChannel.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/KeyValueStreamDataChannel.java
index 185ad9c001..030244e0b8 100644
--- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/KeyValueStreamDataChannel.java
+++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/KeyValueStreamDataChannel.java
@@ -167,11 +167,7 @@ public int write(ReferenceCountedObject<ByteBuffer> referenceCounted)
getMetrics().incContainerOpsMetrics(getType());
assertOpen();
- final long l = Time.monotonicNow();
- int len = writeBuffers(referenceCounted, buffers, super::writeFileChannel);
- getMetrics()
- .incContainerOpsLatencies(getType(), Time.monotonicNow() - l);
- return len;
+ return writeBuffers(referenceCounted, buffers, this::writeFileChannel);
}
static int writeBuffers(ReferenceCountedObject<ByteBuffer> src,
diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java
index 810495b2a7..a88f452167 100644
--- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java
+++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java
@@ -22,6 +22,7 @@
import org.apache.hadoop.hdds.scm.container.common.helpers.StorageContainerException;
import org.apache.hadoop.ozone.container.common.helpers.ContainerMetrics;
import org.apache.hadoop.ozone.container.common.impl.ContainerData;
+import org.apache.hadoop.util.Time;
import org.apache.ratis.statemachine.StateMachine;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -129,9 +130,11 @@ public void close() throws IOException {
final int writeFileChannel(ByteBuffer src) throws IOException {
try {
+ final long startTime = Time.monotonicNow();
final int writeBytes = getChannel().write(src);
metrics.incContainerBytesStats(getType(), writeBytes);
containerData.updateWriteStats(writeBytes, false);
+ metrics.incContainerOpsLatencies(getType(), Time.monotonicNow() - startTime);
return writeBytes;
} catch (IOException e) {
checkVolume();
Comment on lines
143
to
145
| interface WriteMethod { | ||
| int applyAsInt(ByteBuffer src) throws IOException; | ||
| } |
There was a problem hiding this comment.
This is only used in KeyValueStreamDataChannel. Let's keep it here.
| getMetrics() | ||
| .incContainerOpsLatencies(getType(), Time.monotonicNow() - l); | ||
| return len; | ||
| final long start = Time.monotonicNow(); |
There was a problem hiding this comment.
writeBuffers runs in a loop but using the same start time. The time will be double count when there are more than one buffers.
guohao-rosicky
force-pushed
the
guohao-HDDS-10772-dev
branch
from
7eed07e
to
fb186c5
Compare
szetszwo
approved these changes
May 9, 2024
|
Thanks @guohao-rosicky and @szetszwo |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit 7427026)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Not every channel write generated io, but only added to the Buffers object, and in the close channel will be in the Buffers object has not been written to the disk data, the part also need to record metrics.
For the detailed see jira.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10772