New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2. #3855
HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2. #3855
Conversation
@@ -353,8 +353,11 @@ public void notifyConfigurationChanged(long term, long index, | |||
|
|||
@Override | |||
public void pause() { | |||
getLifeCycle().transition(LifeCycle.State.PAUSING); | |||
getLifeCycle().transition(LifeCycle.State.PAUSED); | |||
final LifeCycle lc = getLifeCycle(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes related to bumping ratis version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the tests are failing otherwise.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3251786711/jobs/5337244145#step:5:3128
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3251786711/jobs/5337244434#step:5:3141
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3251786711/jobs/5337244713#step:6:3310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @captainzmc for the patch.
Hi @szetszwo, Would you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the change looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @captainzmc for the work, LGTM +1! this is a important milestone for releasing ozone-1.3.0. Hope that will come soon.
Thanks @adoroszlai @szetszwo @JacksonYao287 for the review. I will cut branch-1.3 and start the release. |
What changes were proposed in this pull request?
We should update Ratis to 2.4.0 to fix gRPC memleak.
After we update ratis to 2.4.0, we will start release ozone 1.3.0.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7149
How was this patch tested?
UT had been update.