Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2. #3855

Merged
merged 11 commits into from Oct 19, 2022

Conversation

captainzmc
Copy link
Member

What changes were proposed in this pull request?

We should update Ratis to 2.4.0 to fix gRPC memleak.
After we update ratis to 2.4.0, we will start release ozone 1.3.0.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7149

How was this patch tested?

UT had been update.

@@ -353,8 +353,11 @@ public void notifyConfigurationChanged(long term, long index,

@Override
public void pause() {
getLifeCycle().transition(LifeCycle.State.PAUSING);
getLifeCycle().transition(LifeCycle.State.PAUSED);
final LifeCycle lc = getLifeCycle();
Copy link
Contributor

@myskov myskov Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes related to bumping ratis version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @captainzmc for the patch.

@captainzmc
Copy link
Member Author

Hi @szetszwo, Would you take another look?

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @captainzmc for the work, LGTM +1! this is a important milestone for releasing ozone-1.3.0. Hope that will come soon.

@JacksonYao287 JacksonYao287 merged commit 03e670b into apache:master Oct 19, 2022
@captainzmc
Copy link
Member Author

Thanks @adoroszlai @szetszwo @JacksonYao287 for the review. I will cut branch-1.3 and start the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants