Refactor controller role to use variables for hostname and host index #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dubee
commented
Jan 19, 2018
•
dubee
commented
- Define variables for frequently referenced operations in controller role
- Move controller.jmxremote.jvmArgs to deploy.yml
dubee
changed the title
dubee
added
the
review
|
@cbickel, can you look at this one when you have a chance? It's just refactoring the controller deployment scripts to make them easier to manage/read. |
cbickel
reviewed
Feb 1, 2018
| @@ -48,17 +56,17 @@ | |||
|
|
|||
| - name: prepare controller ports | |||
| set_fact: | |||
| ports_to_expose: ["{{ controller.basePort + groups['controllers'].index(inventory_hostname) }}:8080", "{{ controller.akka.cluster.basePort + groups['controllers'].index(inventory_hostname) }}:{{ controller.akka.cluster.bindPort }}"] | |||
| ports_to_expose: ["{{ controller.basePort + (controller_index | int) }}:8080", "{{ controller.akka.cluster.basePort + (controller_index | int) }}:{{ controller.akka.cluster.bindPort }}"] | |||
There was a problem hiding this comment.
Is it possible to do the int conversation already on defining the variable? Or would this result in issues on gernerating the name-String?
There was a problem hiding this comment.
@cbickel, unfortunately defining the controller_index as an int results in the variable type being unicode. See below.
Define controller_index as an int:
- name: get controller index
set_fact:
controller_index: "{{ groups['controllers'].index(inventory_hostname) | int }}"
Attempting to add controller_index to an int:
{{ controller.basePort + controller_index }}
Results in this error:
fatal: [192.168.99.100]: FAILED! => {"failed": true, "msg": "Unexpected templating type error occurred on ({{ controller.basePort + controller_index }}:8080): unsupported operand type(s) for +: 'int' and 'unicode'"}
Apparently using set_fact always produces a string: ansible/ansible#4170.
- Define variables for frequently referenced operations controller role - Move controller.jmxremote.jvmArgs to deploy.yml
dubee
force-pushed
the
controller-role
branch
from
5ce6f19
to
14a2efe
Compare
|
PG3 1821 👍 |
|
@cbickel, PG looks good. |
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
…x. (apache#3206) - Define variables for frequently referenced operations controller role - Move controller.jmxremote.jvmArgs to deploy.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.