Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Freeze pipenv version for avoiding issue on documentation generation #4807

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

gustavonihei
Copy link
Contributor

@gustavonihei gustavonihei commented Nov 8, 2021

Summary

This PR intends to add a quick fix for an issue with the latest release of pipenv.

From my investigation seems related to this issue: pypa/pipenv#4828

Impact

No impact, fix for CI job.

Testing

CI build pass.

Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
@Ouss4
Copy link
Member

Ouss4 commented Nov 8, 2021

So what's the root cause? I had some desperate attempts locally. OK I see the updated description.

@Ouss4 Ouss4 linked an issue Nov 8, 2021 that may be closed by this pull request
@gustavonihei
Copy link
Contributor Author

So what's the root cause? I had some desperate attempts locally.

It seems that pipenv run is failing to actually execute the command inside the virtual environment.
The alternative method works: running make run html inside pipenv shell.

@gustavonihei gustavonihei marked this pull request as ready for review November 8, 2021 17:23
@Ouss4
Copy link
Member

Ouss4 commented Nov 8, 2021

It looks like there is a fix for this already but still not part of any release, we'll have to merge this then.

@gustavonihei
Copy link
Contributor Author

It looks like there is a fix for this already but still not part of any release, we'll have to merge this then.

Just for future reference, the fix is already merged upstream:
pypa/pipenv#4838

Once the hotfix is published to pypi, we can unfreeze pipenv version by reverting this commit.

@Ouss4 Ouss4 merged commit 57cba0e into apache:master Nov 8, 2021
@gustavonihei gustavonihei deleted the bugfix/pipenv_documentation branch November 8, 2021 17:55
@jerpelea jerpelea added this to To-Add in Release Notes - 10.3.0 Mar 15, 2022
@jerpelea jerpelea moved this from To-Add to Minor in Release Notes - 10.3.0 Mar 15, 2022
@jerpelea jerpelea moved this from Minor to Not Applicable in Release Notes - 10.3.0 Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Documentation CI always fail recently
2 participants