Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13217 Adjust JavaDoc of ProcessSession to align with changed standard implementation #8819

Closed
wants to merge 1 commit into from

Conversation

EndzeitBegins
Copy link
Contributor

@EndzeitBegins EndzeitBegins commented May 11, 2024

Summary

Adjusts the JavaDoc of ProcessSession to align with the changes introduced to the standard implementation with NIFI-13200 / #8791.
This behavioral change might surprise users thus it seems sensible to adjust the JavaDoc with a notice accordingly.

NIFI-13217

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

UI Contributions

  • NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@EndzeitBegins EndzeitBegins changed the title NIFI-13217 Adjust JavaDoc of ProcessSession to align with standard implementation NIFI-13217 Adjust JavaDoc of ProcessSession to align with changed standard implementation May 11, 2024
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation updates @EndzeitBegins! +1 merging

@EndzeitBegins EndzeitBegins deleted the NIFI-13217 branch May 12, 2024 05:08
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8819

Signed-off-by: David Handermann <exceptionfactory@apache.org>
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8819

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants