[NIFI-13177] ensure consistent typography rendering #8786
Conversation
scottyaslan
commented
May 9, 2024
scottyaslan
commented
scottyaslan
added
the
new ui
scottyaslan
changed the title
There was a problem hiding this comment.
There are still some differences in how we display the component info. We have a component for this, but it isn't 100% compatible with the various ways we use it. I took a quick stab at making it work for all 3 places, let me know what you think. I submitted a PR to your fork/branch: scottyaslan#6
Here are the various flavors of how they are displayed:
Hopefully we can unify to a common component.
|
@rfellows thanks for the updates and the PR. These are great! |
| private getIconClassName(type: ComponentType | string | null) { | ||
| if (type !== null && typeof type !== 'string') { | ||
| return 'icon-drop'; | ||
| } |
There was a problem hiding this comment.
This didn't work for the Parameter Context example. It should show the nifi drop logo for param contexts. I made a quick change to this method that solves the issue.
basically we can't determine the difference between a string and a Component type. need to return the drop icon if it is null or it isn't in the switch (so the default scenario)...
private getIconClassName(type: ComponentType | string | null) {
if (type === null) {
return 'icon-drop';
}
switch (type) {
case ComponentType.Connection:
return 'icon-connect';
case ComponentType.Processor:
return 'icon-processor';
case ComponentType.OutputPort:
return 'icon-port-out';
case ComponentType.InputPort:
return 'icon-port-in';
case ComponentType.ProcessGroup:
return 'icon-group';
case ComponentType.Funnel:
return 'icon-funnel';
case ComponentType.Label:
return 'icon-label';
case ComponentType.RemoteProcessGroup:
return 'icon-group-remote';
default:
return 'icon-drop';
}
}
| if (typeof type === 'string') { | ||
| return type; | ||
| } |
There was a problem hiding this comment.
this is an issue too, sorry for the bad suggestions. we need to remove this check and just return type in the default case of the switch...
