Temporarily downgrade gradle module language level #7367
Conversation
- resolves a "Project Problems" regression - temporary until proper fix is implemented
mbien
added
Gradle
| switch(this) { | ||
| case GROOVY: return Bundle.LBL_DSL_GROOVY(); | ||
| case KOTLIN: return Bundle.LBL_DSL_KOTLIN(); | ||
| default: throw new IllegalStateException("update switch"); |
There was a problem hiding this comment.
I would not throw from toString - if this is user visible the name might look strange, but still conveys the meaning.
| default: throw new IllegalStateException("update switch"); | |
| default: return name(); |
There was a problem hiding this comment.
yeah but I am sure @lkishalmi will fix this properly during NB 23, so we can't really arrive at a situation where enums are added (which are btw a few lines above the toString()) without anyone noticing it.
| case SPOCK: return Bundle.LBL_TFW_SPOCK(); | ||
| case TESTNG: return Bundle.LBL_TFW_TESTNG(); | ||
| case XCTEST: return Bundle.LBL_TFW_XCTEST(); | ||
| default: throw new IllegalStateException("update switch"); |
There was a problem hiding this comment.
| default: throw new IllegalStateException("update switch"); | |
| default: return name(); |
|
do we let the exception throw ? |
Well, that default part should not happen. The new switch checks for completeness. Reverting back to the old syntax and trying to be complete would add a default case. I'm going to split the Gradle module for NB23, as it seems we need some parts kept on Java 8 level for a while, while the majority of code would be fine on Java 17. |
|
Yes, there's a synthesized default that throws an exception in the current code - no difference IMO. @lkishalmi yes, it also makes sense to isolate any class that might be sent over the wire into the daemon process anyway, source level or not? |
fixes #7365
? untested