Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatLaf: fix font of window title when using --fontsize argument (on Windows) #5045

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

DevCharly
Copy link
Member

@DevCharly DevCharly commented Dec 3, 2022

Fixes issue #5041

FlatLaf uses UIManager.getFont("defaultFont") as base for all fonts (similar to Nimbus).

Edit: tested with FlatLaf, Windows L&F, Nimbus and Metal.

@DevCharly DevCharly added Look and Feel Platform [ci] enable platform tests (platform/*) labels Dec 3, 2022
@DevCharly DevCharly added this to the NB17 milestone Dec 3, 2022
@DevCharly DevCharly linked an issue Dec 3, 2022 that may be closed by this pull request
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to Me

Copy link
Contributor

@eirikbakke eirikbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Perhaps test to make sure nothing breaks in the Windows LAF and Aqua LAF.

@eirikbakke
Copy link
Contributor

By the way, I remember FlatLAF had a trick for creating Font objects that work correctly with composite fonts for rendering of e.g. Arabic letters (com.formdev.flatlaf.FlatLAF.createCompositeFont; I use this in my own NetBeans Platform app). Will this keep working with this change?

@lkishalmi lkishalmi merged commit ceacfe5 into apache:master Dec 20, 2022
@DevCharly DevCharly deleted the flatlaf-fontsize-fix branch January 12, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Look and Feel Platform [ci] enable platform tests (platform/*)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlatLaf does not respect fontsize for window title on Windows
3 participants