Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] Port #20482 from v1.x #20921

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

josephevans
Copy link
Contributor

[BUGFIX] Fix reuse of primitives for MKLDNN-AArch64. Fixes #20265. (#20482)

This fix is a workaround for the accuracy issue observed when MXNet is built with Compute Library (ACL).
This change includes:

  • Updating MXNet's AddSign function to generate unique hashes for MKLDNN-ACL backend.
  • Adding DNNL_AARCH64_USE_ACL to CMakeLists.txt
  • Adding Crefeda Rodrigues to the contributors list

Signed-off-by: cfRod crefeda.rodrigues@arm.com

…. (apache#20482)

This fix is a workaround for the accuracy issue observed when MXNet is built with Compute Library (ACL).
This change includes:
* Updating MXNet's AddSign function to generate unique hashes for MKLDNN-ACL backend.
* Adding DNNL_AARCH64_USE_ACL to CMakeLists.txt
* Adding Crefeda Rodrigues to the contributors list

Signed-off-by: cfRod <crefeda.rodrigues@arm.com>
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, clang, windows-gpu, website, sanity, windows-cpu, centos-cpu, miscellaneous, unix-cpu, centos-gpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 28, 2022
@josephevans josephevans merged commit 6ebd3bb into apache:v1.9.x Mar 1, 2022
@josephevans josephevans deleted the v1.9.x_port_20482 branch March 1, 2022 14:58
@waytrue17 waytrue17 mentioned this pull request Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants