Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-2055: Temporarily excluding Cypress from Travis build #1370

Closed
wants to merge 3 commits into from

Conversation

sardell
Copy link
Contributor

@sardell sardell commented Apr 1, 2019

Contributor Comments

Link to ASF ticket: https://issues.apache.org/jira/browse/METRON-2055

The build on Travis is failing because of an unzipping issue during the Cypress installation process. You can find more about this issue and track it here.

While we are waiting for the Cypress team to address this issue, I've removed it from our project dependencies and build process. I also updated a handful of packages with npm audit fix in order to address some high level vulnerabilities.

Testing

You should be able to inspect the Travis logs from this build and see that the Cypress tests have been removed from the build process.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • [ ] Have you written or updated unit tests and or integration tests to verify your changes?

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@tiborm
Copy link
Contributor

tiborm commented Apr 1, 2019

Let's see how Travis reacts to this, but it should pass. Looks good to me. Thanks @sardell ! +1 (non-binding)

Had to updated the package lock due to this bug: angular/angular-cli#11420
@mmiklavc
Copy link
Contributor

mmiklavc commented Apr 1, 2019

We really shouldn't be eliminating or removing tests, let alone an entire test framework. This gives our Travis build results a false sense of correctness. We can't accept any further PRs until this is resolved imo. Can we just manually unzip ourselves instead of depending on yauzl?

@sardell
Copy link
Contributor Author

sardell commented Apr 1, 2019

@mmiklavc I created this PR quickly in response to the build failing in master, but after reading your comment I'm now thinking I'm going to look into a better workaround for this.

@sardell sardell closed this Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants