Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version #670

Merged
merged 2 commits into from Feb 1, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 31, 2022

Based on #427 with an additional fix/test for pom.version and pom.parent.version.

jmax01 and others added 2 commits January 31, 2022 17:16
# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
@gnodet gnodet requested a review from michael-o January 31, 2022 18:54
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase, edit to "[MNG-6727] Using version range in parent and CI Friendly Version fails" and merge into 3.8.x and master.

Thank you!

@gnodet gnodet merged commit d79485f into apache:maven-3.8.x Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants