Improve the use of checkstyle in the build #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with checkstyle is that using the error level as a violation means info and warnings will be ignored. Unfortunately, those are only ignored by the plugin, but checkstyle still see the violations and does not cache the results for files that contains such violations. We need to use info level and some real suppressions so that all files can be cached correctly. |
michael-o
requested changes
Jun 9, 2021
maven-core/src/main/java/org/apache/maven/execution/BuildResumptionAnalyzer.java
Show resolved
Hide resolved
michael-o
approved these changes
Jun 10, 2021
olamy
approved these changes
Jun 10, 2021
sakibguy
added a commit
to sakibguy/maven
that referenced
this pull request
Jul 6, 2021
Improve the use of checkstyle in the build (apache#477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the build time wrt to checkstyle.
Two other PRs will follow eventually to incorporate codehaus-plexus/modello#116, codehaus-plexus/modello#117 and mojohaus/animal-sniffer#165 if possible.
Those 4 fixes make subsequent builds much smoother.