MNG-6771 Fix license issues on binary distribution

[eolivelli]

Draft PR for https://issues.apache.org/jira/browse/MNG-6771

• Start fixing the template for LICENSE file
• Have consistent naming for LICENSE file and final jars by removing 'classifier' from the name of jars
• Introduce a script to check for license, from Apache BookKeeper project, original author ivank@apache.org

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MNG-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[eolivelli]

This is just the adaptation of
https://github.com/apache/bookkeeper/blob/master/dev/check-binary-license

That in turn verifies for
http://bookkeeper.apache.org/community/licensing

We will adapt it to whatever rules we decide for Maven

we could also convert to a Groovy/Python script,
honestly I would love to see these kind of checks in the "Apache RAT" project

[eolivelli]

this is to be changed

[eolivelli]

@hboutemy I have fixed the download of ASL license files.
I have also added a tweak to bundle jsoup license: add an explicit dependency and then exlucde the jar file from the "lib" directory.

I can't find the point in code where we are generating the NOTICE file for the Binary distribution.
It is not a raw source file copied from somewhere.

I need to be able to manually write this file.
This is the last step in this work

[eolivelli]

@hboutemy when I am referring to '.license' files I am talking about this line:
https://github.com/apache/maven/blob/master/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm#L54

that makes that the license files are downloaded to lib/xxxx.license

[hboutemy]

I have also added a tweak to bundle jsoup license: add an explicit dependency and then exlucde the jar file from the "lib" directory.

nice tweak :)

I can't find the point in code where we are generating the NOTICE file for the Binary distribution.

it comes from maven-remote-resources-plugin processing org.apache:apache-jar-resource-bundle:1.4, cf https://github.com/apache/maven-resources/tree/trunk/apache-jar-resource-bundle/src/main/resources/META-INF

[eolivelli]

Thank you @hboutemy for moving forward.
The last step is to create the NOTICE file.
Are you working on it ?
I have time to do the first step this evening. I will go thru the list of depedencies and collect manually all of the texts to be reported in NOTICE file

[eolivelli]

@hboutemy I have written on JIRA the contents I think we need to write in NOTICE
is there any way to append contents to it comes from maven-remote-resources-plugin processing org.apache:apache-jar-resource-bundle:1.4, cf https://github.com/apache/maven-resources/tree/trunk/apache-jar-resource-bundle/src/main/resources/META-INF

without releasing a new version of maven-resources ?

[hboutemy]

@eolivelli if you copy LICENSE.vm to NOTICE.vm, you'll see that you can do the same Velocity append in NOTICE than what is currently done for LICENSE

[hboutemy]

ok for me

[eolivelli]

Thank you @hboutemy
I will merge as soon as CI is blue https://builds.apache.org/job/maven-box/job/maven/job/MNG-6771/15/

[eolivelli]

committed as f8bd6d5

thank you so much @hboutemy !