Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-6665] toolchain.xml file should support environment variables #251

Merged
merged 4 commits into from Jun 8, 2019
Merged

[MNG-6665] toolchain.xml file should support environment variables #251

merged 4 commits into from Jun 8, 2019

Commits on May 31, 2019

  1. [MNG-6665] toolchain.xml file should support environment variables 

    Submitted by: Mike Mol and Martin Kanters
    @MartinKanters
    MartinKanters committed May 31, 2019
    Copy the full SHA
    65a56a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. [MNG-6665] toolchain.xml file should support environment variables 

    Submitted by: Mike Mol and Martin Kanters

Used constructor injection to inject the toolchainsWriter, instead of always making a new one. Constructor injection is used, in order to be able to unit test against a real instance of the toolchainsWriter. Made it a @nAmed @singleton instead of @component to be consistent with the DefaultToolchainsReader.
    @MartinKanters
    MartinKanters committed Jun 3, 2019
    Copy the full SHA
    62cd2cc View commit details
    Browse the repository at this point in the history

  2. [MNG-6665] toolchain.xml file should support environment variables 

    Submitted by: Mike Mol and Martin Kanters

Added ourselves to the contributors list
    @MartinKanters
    MartinKanters committed Jun 3, 2019
    Copy the full SHA
    a23d4d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. [MNG-6665] toolchain.xml file should support environment variables 

    Submitted by: Mike Mol and Martin Kanters

Added field injection again, instead of constructor injection, to be consistent with the codebase and because it will probably not work with the way maven generates a injection descriptor on compile time.
    @MartinKanters
    MartinKanters committed Jun 6, 2019
    Copy the full SHA
    2990d0a View commit details
    Browse the repository at this point in the history