Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-6405] Fix basedir in MavenProject.deepCopy #225

Merged
merged 4 commits into from Apr 16, 2019
Merged

[MNG-6405] Fix basedir in MavenProject.deepCopy #225

merged 4 commits into from Apr 16, 2019

Commits on Jan 3, 2019

  1. [MNG-6405] Fix basedir in MavenProject.deepCopy.

    @jglick
    jglick committed Jan 3, 2019
    Copy the full SHA
    9c6bdb6 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. Merge branch 'master' into forked-basedir-MNG-6405

    @jglick
    jglick committed Apr 15, 2019
    Copy the full SHA
    aaeed6f View commit details
    Browse the repository at this point in the history

  2. Reproduced bug in test. 

    Failure without patch:
junit.framework.AssertionFailedError: Base directory is preserved across clone expected:<…/maven-core/target/test-classes> but was:<…/maven-core/target/test-classes/target>
	at org.apache.maven.project.MavenProjectTest.testCloneWithBaseDir(MavenProjectTest.java:188)
    @jglick
    jglick committed Apr 15, 2019
    Copy the full SHA
    0954d30 View commit details
    Browse the repository at this point in the history

  3. Code style. Not enforced in tests during build?

    @jglick
    jglick committed Apr 15, 2019
    Copy the full SHA
    2217816 View commit details
    Browse the repository at this point in the history