Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging not found #1507

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix packaging not found #1507

merged 2 commits into from
May 16, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented May 15, 2024

No description provided.

@gnodet gnodet requested a review from cstamas May 16, 2024 05:38
@gnodet gnodet marked this pull request as ready for review May 16, 2024 05:38
@gnodet
Copy link
Contributor Author

gnodet commented May 16, 2024

@cstamas @wendigo this will hopefully fix the problem in beta-2 for trino. I'd like to merge it and have trinodb/trino#21966 point to the snapshot repository... ?

@wendigo
Copy link

wendigo commented May 16, 2024

@gnodet I can test with a snapshot - please share a link to the build (zip)

Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this looks hacky as we discussed with Guillaume

@gnodet gnodet merged commit accbbcf into apache:master May 16, 2024
13 checks passed
@wendigo
Copy link

wendigo commented May 16, 2024

I couldn't test it through the wrapper:

grep distributionUrl .mvn/wrapper/maven-wrapper.properties
distributionUrl=https://repository.apache.org/content/repositories/snapshots/org/apache/maven/apache-maven/4.0.0-beta-3-SNAPSHOT/apache-maven-4.0.0-beta-3-20240515.173255-2-bin.zip
./mvnw: line 246: /var/folders/n4/vl45d5rn5n1_yk_pl5xkpd380000gn/T/tmp.CNmLdxlcJH/apache-maven-4.0.0-beta-3-20240515.173255-2/mvnw.url: No such file or directory

I'm testing it locally now.

@wendigo
Copy link

wendigo commented May 16, 2024

Locally it works flawlessly :) Thanks @gnodet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants