Skip to content

Commit

Permalink
[MNG-7216] [Regression] Revert MNG-7170
Browse files Browse the repository at this point in the history
This reverts commit 5a89973.

This closes #524
  • Loading branch information
michael-o committed Sep 12, 2021
1 parent c76c9d9 commit 383cabf
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 53 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
import org.apache.maven.model.Plugin;
import org.apache.maven.model.building.FileModelSource;
import org.apache.maven.model.building.ModelBuildingRequest;
import org.apache.maven.model.building.ModelProblem;
import org.apache.maven.model.building.ModelProblem.Severity;
import org.apache.maven.model.building.ModelSource;
import org.apache.maven.shared.utils.io.FileUtils;

Expand Down Expand Up @@ -85,30 +83,6 @@ public void testBuildFromModelSource()
assertNotNull( result.getProject().getParentFile() );
}

public void testBuildFromModelSourceResolvesBasedir()
throws Exception
{
File pomFile = new File( "src/test/resources/projects/modelsourcebasedir/pom.xml" );
MavenSession mavenSession = createMavenSession( null );
ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
configuration.setRepositorySession( mavenSession.getRepositorySession() );
ModelSource modelSource = new FileModelSource( pomFile );
ProjectBuildingResult result =
getContainer().lookup( org.apache.maven.project.ProjectBuilder.class ).build( modelSource, configuration );

assertEquals( pomFile.getAbsoluteFile(), result.getProject().getModel().getPomFile().getAbsoluteFile() );
int errors = 0;
for ( ModelProblem p : result.getProblems() )
{
if ( p.getSeverity() == Severity.ERROR )
{
errors++;
}
}
assertEquals( 0, errors );
}


public void testVersionlessManagedDependency()
throws Exception
{
Expand Down
19 changes: 0 additions & 19 deletions maven-core/src/test/resources/projects/modelsourcebasedir/pom.xml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -624,14 +624,7 @@ private Model readModel( ModelSource modelSource, File pomFile, ModelBuildingReq
throw problems.newModelBuildingException();
}

if ( pomFile != null )
{
model.setPomFile( pomFile );
}
else if ( modelSource instanceof FileModelSource )
{
model.setPomFile( ( (FileModelSource) modelSource ).getFile() );
}
model.setPomFile( pomFile );

problems.setSource( model );
modelValidator.validateRawModel( model, request, problems );
Expand Down

0 comments on commit 383cabf

Please sign in to comment.