Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update shared utils #652

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

update shared utils #652

wants to merge 5 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 29, 2023

Let's see what the CI thinks. Locally I can't get everything to pass at head.

@elharo elharo requested a review from michael-o May 29, 2023 20:56
michael-o
michael-o requested changes May 29, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incomplete, you need to remove the jansi override as well. See my PR.

@michael-o
Copy link
Member

Did you check? Is it really used directly?

elharo
elharo commented May 29, 2023
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like jansi is imported anywhere, unless it's part of the shading somehow. Tentatively it looks like we can remove it completely.

@michael-o michael-o self-requested a review May 30, 2023 09:05
@michael-o
Copy link
Member

Now it fails with the same output I had...

@michael-o michael-o marked this pull request as draft May 30, 2023 09:06
@elharo
Copy link
Contributor Author

elharo commented May 31, 2023

[INFO]
Error: Failures:
Error: BasicTest.testEnvVar:23
Expected: null
got: "dwdijoi"

@elharo
Copy link
Contributor Author

elharo commented May 31, 2023

That is a weird failure. Not immediately obvious how it's caused by this PR though it likely is. Maybe something involving PowerMock? still digging...

@michael-o michael-o removed their request for review June 8, 2023 08:26
@michael-o
Copy link
Member

https://issues.apache.org/jira/browse/MSHARED-1014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elharo @michael-o