Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUREFIRE-2044] Upgrade Maven Verifier to 1.8.0 #507

Merged
merged 1 commit into from Apr 5, 2022
Merged

[SUREFIRE-2044] Upgrade Maven Verifier to 1.8.0 #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 1 addition & 11 deletions pom.xml
View file
Open in desktop
Expand Up @@ -230,17 +230,7 @@
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-verifier</artifactId>
<version>1.7.2</version>
<exclusions>
<exclusion>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
</exclusion>
<exclusion>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</exclusion>
</exclusions>
<version>1.8.0</version>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
Expand Down
4 changes: 2 additions & 2 deletions surefire-its/src/test/java/org/apache/maven/surefire/its/fixture/MavenLauncher.java
View file
Open in desktop
Expand Up @@ -186,9 +186,9 @@ public MavenLauncher addEnvVar( String key, String value )
return this;
}

public MavenLauncher assertNotPresent( String subFile )
public MavenLauncher verifyFileNotPresent( String subFile ) throws VerificationException
{
getVerifier().assertFileNotPresent( getValidator().getSubFile( subFile ).getAbsolutePath() );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this method renamed in new verifier?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old method was deprecated
apache/maven-verifier#9

getVerifier().verifyFileNotPresent( getValidator().getSubFile( subFile ).getAbsolutePath() );
return this;
}

Expand Down
2 changes: 1 addition & 1 deletion ...its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire772NoFailsafeReportsIT.java
View file
Open in desktop
Expand Up @@ -104,7 +104,7 @@ private SurefireLauncher unpack()
throws VerificationException, IOException
{
final SurefireLauncher unpack = unpack( "surefire-772-no-failsafe-reports" );
unpack.maven().deleteSiteDir().skipClean().failNever().assertNotPresent( "site" );
unpack.maven().deleteSiteDir().skipClean().failNever().verifyFileNotPresent( "site" );
return unpack;
}

Expand Down