Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUREFIRE-2008] Upgrade animal-sniffer-maven-plugin to 1.21 #468

Merged
merged 1 commit into from Feb 12, 2022
Merged

[SUREFIRE-2008] Upgrade animal-sniffer-maven-plugin to 1.21 #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions pom.xml
View file
Open in desktop
Expand Up @@ -452,11 +452,10 @@
<proc>none</proc>
</configuration>
</plugin>
<!-- NOTE: animal sniffer does not check test classes: https://jira.codehaus.org/browse/MANIMALSNIFFER-40 -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-maven-plugin</artifactId>
<version>1.17</version>
<version>1.21</version>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
Expand Down Expand Up @@ -632,10 +631,13 @@
<executions>
<execution>
<id>signature-check</id>
<!-- we use offline jacoco instrumentation so check must be done after restoring original classes -->
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
<configuration>
<checkTestClasses>true</checkTestClasses>
<signature>
<groupId>org.codehaus.mojo.signature</groupId>
<artifactId>java18</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion ...ire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java
View file
Open in desktop
Expand Up @@ -318,7 +318,7 @@ public void shouldReadMultipleStringsAndShiftedInput() throws Exception

Memento memento = thread.new Memento();
// whatever position will be compacted to 0
( (Buffer) ( (Buffer) memento.getByteBuffer().limit( 974 ) ) ).position( 974 );
( (Buffer) memento.getByteBuffer() ).limit( 974 ).position( 974 );

StringBuilder expected = new StringBuilder( "789" );
for ( int i = 0; i < 11; i++ )
Expand Down