New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-2006] Don't use Services Transformer in shadefire #462
Conversation
It's good that you have looked at it. The POJO test should not be modified like this because the users will not use the |
Maybe it is a bug in the |
I hope it is not issue |
Anyway, if you like to test the ShadeFire, it's good but we should also keep the original IT and this can be accomplished by adding a new Maven profile for ShadeFire in the IT's POM which is maybe the most simple solution. |
I will fix duplicate services and prepare separate IT test |
fdaf79d
to
2d3dad7
Compare
Fixed:
|
<name>shadefire usage test</name> | ||
|
||
<properties> | ||
<maven.compiler.source>1.8</maven.compiler.source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we can open more alternatives for test errors if we build the sources against ${java.specificaation.version}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your proposition?
Most of IT tests have the same, even with 1.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old tests with j7 are old tests, that's the history.
Once, Robert Scholte provided an integration test with
<maven.compiler.source>${java.specificaation.version}</maven.compiler.source>
<maven.compiler.target>${java.specificaation.version}</maven.compiler.target>
It was very interesting configuration. We know that the bytecode is not always the same beween versions which is good for us because we can find more bugs in these tests.
2d3dad7
to
57537af
Compare
57537af
to
6d08f29
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
SUREFIRE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean install
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.