Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUREFIRE-1909] Replace --add-exports with --add-opens #461

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[SUREFIRE-1909] Replace --add-exports with --add-opens #461

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27ae6c1
SUREFIRE-1909 Replace --add-exports with --add-opens
NilsRenaud Feb 8, 2022
bc4ba50
SUREFIRE-1909 permit to set the Jpms test openness mode
NilsRenaud Feb 9, 2022
1dc09d2
SUREFIRE-1909 Add integration tests
NilsRenaud Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfiguration.java
View file
Open in desktop
Expand Up @@ -183,7 +183,7 @@ File createArgsFile( @Nonnull String moduleName, @Nonnull List<String> modulePat

for ( String pkg : packages )
{
args.append( "--add-exports" )
args.append( "--add-opens" )
.append( NL )
.append( moduleName )
.append( '/' )
Expand Down
2 changes: 1 addition & 1 deletion .../org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfigurationTest.java
View file
Open in desktop
Expand Up @@ -116,7 +116,7 @@ public void shouldCreateModularArgsFile() throws Exception
.isEqualTo( "abc=\"" + replace( patchFile.getPath(), "\\", "\\\\" ) + "\"" );

assertThat( argsFileLines.get( 6 ) )
.isEqualTo( "--add-exports" );
.isEqualTo( "--add-opens" );

assertThat( argsFileLines.get( 7 ) )
.isEqualTo( "abc/org.apache.abc=ALL-UNNAMED" );
Expand Down