Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jsr305 from 2.0.3 to 3.0.2 #428

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2022

Bumps jsr305 from 2.0.3 to 3.0.2.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 3, 2022
@slawekjaranowski
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/com.google.code.findbugs-jsr305-3.0.2 branch from 6ef9eb7 to ef3b4f1 Compare January 7, 2022 09:07
@slawekjaranowski slawekjaranowski force-pushed the dependabot/maven/com.google.code.findbugs-jsr305-3.0.2 branch from 4c5eb73 to a6f0beb Compare January 8, 2022 00:26
@slawekjaranowski slawekjaranowski self-assigned this Jan 8, 2022
@Tibor17
Copy link
Contributor

Tibor17 commented Jan 8, 2022

@slawekjaranowski
I have the first question regarding the following POM section in the commit.

          <execution>
             <id>show-test-classpath</id>
             <phase>generate-sources</phase>
             <goals>
               <goal>build-classpath</goal>
             </goals>
             <configuration>
               <includeScope>test</includeScope>
             </configuration>
           </execution>

How it is related to JSR 305? Did the build fail with this upgrade?
You make it for better visibility of the CP in the logs?
The try-catch and printStackTrace is the same case?

The toURI().toURL() or the old class URL is a typical warning in IDE. It is a cosmetic change. We can keep it in this PR, I don't mind, but the changes should go to one commit, and the log visibility changes in another commit. And then it would be clear what purpose you have with it and also the history in the Git would be more clear to everybody.

@slawekjaranowski
Copy link
Member

It was my tests ... I will cleanup it
Please look #435

@slawekjaranowski slawekjaranowski force-pushed the dependabot/maven/com.google.code.findbugs-jsr305-3.0.2 branch from 66d230c to ef3b4f1 Compare January 8, 2022 18:08
@slawekjaranowski
Copy link
Member

@dependabot rebase

Bumps jsr305 from 2.0.3 to 3.0.2.

---
updated-dependencies:
- dependency-name: com.google.code.findbugs:jsr305
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/com.google.code.findbugs-jsr305-3.0.2 branch from ef3b4f1 to 3aa35e5 Compare January 9, 2022 09:57
@slawekjaranowski slawekjaranowski merged commit 71fdc14 into master Jan 9, 2022
@slawekjaranowski slawekjaranowski deleted the dependabot/maven/com.google.code.findbugs-jsr305-3.0.2 branch January 9, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants