Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surefire shared utils, #424

Closed
wants to merge 3 commits into from
Closed

Surefire shared utils, #424

wants to merge 3 commits into from

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Jan 1, 2022

We are aiming for an upgrade of the version of org.apache.maven.surefire.shared.lang3.JavaVersion which means that we have to install/deploy current version of surefire-shared-utils.
Then we are able to implement the method isSecurityManagerSupported() within the module surefire-api using the enum JavaVersion.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jan 1, 2022 •
edited

@slawekjaranowski
I agree that comparing the Java version would be more straightaway solution. To get there I had to proceed with the first two commits. The first makes the module surefire-shared-utils available to our project with current project version. And then I had to upgrade commons-lang3 of course. And the third commit is just our method in module surefire-api.

@slawekjaranowski
Copy link
Member

There is issues to link:

slawekjaranowski
slawekjaranowski requested changes Jan 2, 2022
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in three separate PR

eolivelli
eolivelli approved these changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jan 2, 2022

@slawekjaranowski
Of course I can create PRs for these commits.
This draft provides everybody with context for JDK 18 fix (see the PR #422) regarding deprecated SecurityManager.

@slawekjaranowski slawekjaranowski mentioned this pull request Jan 2, 2022
Closed
8 tasks
@Tibor17 Tibor17 mentioned this pull request Jan 2, 2022
Closed
8 tasks
@Tibor17
Copy link
Contributor Author

Tibor17 commented Jan 2, 2022

@slawekjaranowski
@eolivelli
The first commit appears in #426.

@Tibor17 Tibor17 closed this Jan 19, 2022
@Tibor17 Tibor17 deleted the surefire-shared-utils branch January 19, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Tibor17 @slawekjaranowski @eolivelli