[SUREFIRE-2058] Flip and clear output char buffer after each chunk read

Overflow can happen even when output buffer has still some remaining space left
apache · Apr 25, 2022 · ef373d7 · ef373d7
1 parent a771bbb
commit ef373d7
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoder.java b/surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoder.java
@@ -326,11 +326,8 @@ private String readString( @Nonnull final Memento memento, @Nonnegative final in
             }
             while ( isLastChunk && bytesToDecode > 0 && output.hasRemaining() );
 
-            if ( isLastChunk || !output.hasRemaining() )
-            {
-                strings.add( ( (Buffer) output ).flip().toString() );
-                ( (Buffer) output ).clear();
-            }
+            strings.add( ( (Buffer) output ).flip().toString() );
+            ( (Buffer) output ).clear();
         }
 
         memento.getDecoder().reset();