Skip to content

Commit

Permalink
[SUREFIRE-2240] Don't manage JUnit5 artifact versions
Browse files Browse the repository at this point in the history
This allows to more easily overwrite the version via plugin dependencies
  • Loading branch information
kwin committed Mar 5, 2024
1 parent 2fed802 commit d860529
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
8 changes: 0 additions & 8 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -308,14 +308,6 @@
<version>${jacocoVersion}</version>
<classifier>runtime</classifier>
</dependency>
<dependency>
<!-- Do not upgrade, leads to test failures, needs analysis -->
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.9.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
<dependencies>
Expand Down
10 changes: 10 additions & 0 deletions surefire-providers/surefire-junit-platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@
<tag>surefire-3.0.0-M8</tag>
</scm>

<properties>
<!-- common version suffix by platform and other junit5 artifacts, compare with https://github.com/junit-team/junit5/blob/main/gradle.properties -->
<junit5VersionSuffix>9.3</junit5VersionSuffix>
<junit5Version>5.${junit5VersionSuffix}</junit5Version>
<junitPlatformVersion>1.${junit5VersionSuffix}</junitPlatformVersion>
</properties>

<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
Expand All @@ -89,15 +96,18 @@
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-launcher</artifactId>
<version>${junitPlatformVersion}</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit5Version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit5Version}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down

0 comments on commit d860529

Please sign in to comment.