[SUREFIRE-2075] Only set thread count if spec'd

apache · Apr 25, 2022 · 1f3013a · 1f3013a
1 parent 2657a32
commit 1f3013a
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/...ire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNGMapConfigurator.java b/...ire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNGMapConfigurator.java
@@ -28,7 +28,6 @@
 import org.testng.TestNG;
 import org.testng.xml.XmlSuite;
 
-import static java.lang.Integer.parseInt;
 import static org.apache.maven.surefire.api.booter.ProviderParameterNames.PARALLEL_PROP;
 import static org.apache.maven.surefire.api.booter.ProviderParameterNames.THREADCOUNT_PROP;
 import static org.apache.maven.surefire.testng.conf.AbstractDirectConfigurator.loadListenerClasses;
@@ -68,9 +67,18 @@ public void configure( XmlSuite suite, Map<String, String> options )
     protected void configureThreadCount( XmlSuite suite, Map<String, String> options )
         throws TestSetFailedException
     {
-        String threadCountAsString = options.get( THREADCOUNT_PROP );
-        int threadCount = threadCountAsString == null ? 1 : parseInt( threadCountAsString );
-        suite.setThreadCount( threadCount );
+        String threadCount = options.get( THREADCOUNT_PROP );
+        if ( threadCount != null )
+        {
+            try
+            {
+                suite.setThreadCount( Integer.parseInt( threadCount ) );
+            }
+            catch ( NumberFormatException e )
+            {
+                throw new TestSetFailedException( "Non-integer TestNG [threadcount] setting: " + threadCount, e );
+            }
+        }
     }
 
     protected void configureParallel( XmlSuite suite, Map<String, String> options )