refactor RunOrderParameters constructors

apache · Apr 7, 2022 · 157d2d9 · 157d2d9
1 parent 1c06971
commit 157d2d9
Showing 1 changed file with 11 additions and 15 deletions.
diff --git a/surefire-api/src/main/java/org/apache/maven/surefire/api/testset/RunOrderParameters.java b/surefire-api/src/main/java/org/apache/maven/surefire/api/testset/RunOrderParameters.java
@@ -22,10 +22,13 @@
 import java.io.File;
 import org.apache.maven.surefire.api.util.RunOrder;
 
+import static org.apache.maven.surefire.api.util.RunOrder.ALPHABETICAL;
+import static org.apache.maven.surefire.api.util.RunOrder.DEFAULT;
+
 /**
  * @author Kristian Rosenvold
  */
-public class RunOrderParameters
+public final class RunOrderParameters
 {
     private final RunOrder[] runOrder;
 
@@ -35,35 +38,29 @@ public class RunOrderParameters
 
     public RunOrderParameters( RunOrder[] runOrder, File runStatisticsFile )
     {
-        this.runOrder = runOrder;
-        this.runStatisticsFile = runStatisticsFile;
-        this.runOrderRandomSeed = null;
+        this( runOrder, runStatisticsFile, null );
     }
 
     public RunOrderParameters( String runOrder, File runStatisticsFile )
     {
-        this.runOrder = runOrder == null ? RunOrder.DEFAULT : RunOrder.valueOfMulti( runOrder );
-        this.runStatisticsFile = runStatisticsFile;
-        this.runOrderRandomSeed = null;
+        this( runOrder, runStatisticsFile, null );
     }
 
-    public RunOrderParameters( RunOrder[] runOrder, File runStatisticsFile, Long runOrderRandomSeed )
+    public RunOrderParameters( String runOrder, File runStatisticsFile, Long runOrderRandomSeed )
     {
-        this.runOrder = runOrder;
-        this.runStatisticsFile = runStatisticsFile;
-        this.runOrderRandomSeed = runOrderRandomSeed;
+        this( runOrder == null ? DEFAULT : RunOrder.valueOfMulti( runOrder ), runStatisticsFile, runOrderRandomSeed );
     }
 
-    public RunOrderParameters( String runOrder, File runStatisticsFile, Long runOrderRandomSeed )
+    public RunOrderParameters( RunOrder[] runOrder, File runStatisticsFile, Long runOrderRandomSeed )
     {
-        this.runOrder = runOrder == null ? RunOrder.DEFAULT : RunOrder.valueOfMulti( runOrder );
+        this.runOrder = runOrder;
         this.runStatisticsFile = runStatisticsFile;
         this.runOrderRandomSeed = runOrderRandomSeed;
     }
 
     public static RunOrderParameters alphabetical()
     {
-        return new RunOrderParameters( new RunOrder[]{ RunOrder.ALPHABETICAL }, null );
+        return new RunOrderParameters( new RunOrder[]{ ALPHABETICAL }, null );
     }
 
     public RunOrder[] getRunOrder()
@@ -80,5 +77,4 @@ public File getRunStatisticsFile()
     {
         return runStatisticsFile;
     }
-
 }