[MSITE-871] Upgrade Maven Javadoc Plugin in integration tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test failed on macOS with Java above 8; now they pass with Java 8, 11 and 15 on macOS.
|
This is cool, thank you! |
elharo
approved these changes
Mar 1, 2021
|
Running through Jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-site-plugin/job/msite-871/ Given that this fixes some tests, and does not break anything new I'm comfortable merging it. We can fix the remaining two in the next PR. |
These test failed on macOS with Java above 8; now they pass with Java 8, 11 and 15 on macOS.
|
The remaining tests are also fixed by upgrading the Maven Javadoc Plugin. Just pushed. |
|
Looks good. CI is slow today, but I'll merge as soon as they all pass. Thanks! |
|
Awesome news! :-) |
bertysentry
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test failed on macOS with Java above 8; now they pass with
Java 8, 11 and 15 on macOS.