Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSITE-859] update apache commons lang and IO #25

Merged
merged 1 commit into from May 24, 2020
Merged

[MSITE-859] update apache commons lang and IO #25

merged 1 commit into from May 24, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 24, 2020

michael-o
michael-o reviewed May 24, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be done until master has been officially promoted to Java 8.

elharo
elharo commented May 24, 2020
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think commons-lang 3.8.1 is the last release that supports Java 7.
commons-io still supports java 7 at head.

michael-o
michael-o approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@elharo elharo merged commit c987958 into master May 24, 2020
@elharo elharo deleted the test branch May 24, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elharo @michael-o