Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSITE-757] remove Maven 2 support #24

Merged
merged 5 commits into from May 26, 2020
Merged

[MSITE-757] remove Maven 2 support #24

merged 5 commits into from May 26, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 24, 2020

@elharo
-a
8f8d185 
remove Maven 2 support
@elharo elharo requested a review from olamy May 24, 2020 11:54
michael-o
michael-o reviewed May 24, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a JIRA issue already, can you link it with that?

@elharo elharo changed the title remove Maven 2 support [MSITE-858] remove Maven 2 support May 24, 2020
@elharo elharo changed the title [MSITE-858] remove Maven 2 support [MSITE-845] remove Maven 2 support May 24, 2020
elharo
elharo commented May 24, 2020
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked

@slachiewicz
Copy link
Member

We already have PR #12

@elharo
Copy link
Contributor Author

elharo commented May 24, 2020

Can that one be merged?

@slachiewicz
Copy link
Member

build looks green https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-site-plugin/job/MSITE-845/

olamy
olamy approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@elharo
Copy link
Contributor Author

elharo commented May 25, 2020

@Tibor17 do you want to merge #12 before I merge this one?

@slachiewicz
Copy link
Member

Ok #12 merged to master. Please rebase a d resolve conflicts in this pr

@elharo elharo changed the title [MSITE-845] remove Maven 2 support [MSITE-757] remove Maven 2 support May 26, 2020
@elharo elharo merged commit f37789b into master May 26, 2020
@elharo elharo deleted the plex branch May 26, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o left review comments

@olamy olamy olamy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@elharo @slachiewicz @olamy @michael-o