Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… #183

Merged
merged 1 commit into from May 4, 2024

Conversation

michael-o
Copy link
Member

…tput

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSITE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSITE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o requested a review from kwin April 19, 2024 17:49
michael-o added a commit that referenced this pull request Apr 30, 2024
asfgit pushed a commit that referenced this pull request May 1, 2024
asfgit pushed a commit that referenced this pull request May 1, 2024
@michael-o michael-o marked this pull request as ready for review May 1, 2024 19:48
@michael-o
Copy link
Member Author

If I don't get any objections will merge this until end of week.

@asfgit asfgit merged commit b3a063b into master May 4, 2024
52 of 61 checks passed
@michael-o michael-o deleted the MSITE-1006 branch May 4, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants