-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSITE-945] Remove dependency on Commons IO #174
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But what about the actual code? |
Maybe I missed something here then; removed the dependency and thought that
there will be compilation or verification error if something broke, but it
didn't so then thought that nothing is dependent on commons-io classes. Or
did I miss something, can you elaborate?
…On Mon, Mar 4, 2024 at 10:22 PM Michael Osipov ***@***.***> wrote:
But what about the actual code?
—
Reply to this email directly, view it on GitHub
<#174 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGWA5SXBWLJC2MK6ALT3B33YWTQYNAVCNFSM6AAAAABEF5SH7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQ3TSNJQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Ah, well now I see. Will look into it and come back.
Thx for now.
On Mon, Mar 4, 2024 at 10:27 PM Fredrik Anderson ***@***.***>
wrote:
… Maybe I missed something here then; removed the dependency and thought
that there will be compilation or verification error if something broke,
but it didn't so then thought that nothing is dependent on commons-io
classes. Or did I miss something, can you elaborate?
On Mon, Mar 4, 2024 at 10:22 PM Michael Osipov ***@***.***>
wrote:
> But what about the actual code?
>
> —
> Reply to this email directly, view it on GitHub
> <#174 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGWA5SXBWLJC2MK6ALT3B33YWTQYNAVCNFSM6AAAAABEF5SH7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQ3TSNJQHE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Hi again,
Now I have updated with code in a branch in my fork at:
https://github.com/FredrikAnderson/maven-site-plugin/tree/feature/msite-945
Since I needed to do an extra commit I removed my feature-branch in my
fork, which closed the PR in "main" repo.
Please propose how to proceed.
Fredrik
On Mon, Mar 4, 2024 at 10:30 PM Fredrik Anderson ***@***.***>
wrote:
… Ah, well now I see. Will look into it and come back.
Thx for now.
On Mon, Mar 4, 2024 at 10:27 PM Fredrik Anderson ***@***.***>
wrote:
> Maybe I missed something here then; removed the dependency and thought
> that there will be compilation or verification error if something broke,
> but it didn't so then thought that nothing is dependent on commons-io
> classes. Or did I miss something, can you elaborate?
>
> On Mon, Mar 4, 2024 at 10:22 PM Michael Osipov ***@***.***>
> wrote:
>
>> But what about the actual code?
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#174 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AGWA5SXBWLJC2MK6ALT3B33YWTQYNAVCNFSM6AAAAABEF5SH7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQ3TSNJQHE>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSITE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MSITE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
[x ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[x ] In any other case, please file an Apache Individual Contributor License Agreement.
Straightforward fix, deleted dependency and module is still verified OK.